Difference between revisions of "Talk:Fishing Log: Mok Oogl Island"
| (2 intermediate revisions by 2 users not shown) | |||
| Line 1: | Line 1: | ||
@OnyxVindicator I've changed the template call from item icon back to gather as its broke a couple of pages that pull data from these fishing log pages. But if I'm honest these fishing logs were just created to pull the data for other pages. The information you are putting on would ideally be better on the individual fish pages I think [[User:JohnnySolas|JohnnySolas]] ([[User talk:JohnnySolas|talk]]) 20:12, 11 April 2023 (UTC) | @OnyxVindicator I've changed the template call from item icon back to gather as its broke a couple of pages that pull data from these fishing log pages. But if I'm honest these fishing logs were just created to pull the data for other pages. The information you are putting on would ideally be better on the individual fish pages I think [[User:JohnnySolas|JohnnySolas]] ([[User talk:JohnnySolas|talk]]) 20:12, 11 April 2023 (UTC) | ||
@JohnnySolas My change to this page was a limited test, to see what issues it caused. I was intending to update more of the Fishing Log pages to give this data in a single at-a-glance table, to mimic the the overall style of Lulu's Tools for Ocean Fishing (https://ffxiv.pf-n.co/ocean-fishing). Teamcraft 90% works this way, but requires way too reading of multiple tables to figure out what's going on.<br> | @JohnnySolas My change to this page was a limited test, to see what issues it caused. I was intending to update more of the Fishing Log pages to give this data in a single at-a-glance table, to mimic the the overall style of Lulu's Tools for Ocean Fishing (https://ffxiv.pf-n.co/ocean-fishing). Teamcraft 90% works this way, but requires way too reading of multiple tables to figure out what's going on (and doesn't have additional requirements easily visible by those tables).<br> | ||
If this is interfering with the data pulls for other pages, would it be better to just revert the page entirely? Or perhaps move the table to the ''bottom'' of the page in its own section? [[User:OnyxVindicator|OnyxVindicator]] ([[User talk:OnyxVindicator|talk]]) 23:12, 15 April 2023 (UTC) | If this is interfering with the data pulls for other pages, would it be better to just revert the page entirely? Or perhaps move the table to the ''bottom'' of the page in its own section? [[User:OnyxVindicator|OnyxVindicator]] ([[User talk:OnyxVindicator|talk]]) 23:12, 15 April 2023 (UTC) | ||
@OnyxVindicator - I don't think you need to change back just using :[[Template:gather]] instead of :[[Template:item icon]] should ensure the other pages pulls don't get affected - they are the same template expect gather adds an extra property so other pages can pull from it. Or yes if you want to put the table into its on section that works too and you could use item icon like you did. [[User:JohnnySolas|JohnnySolas]] ([[User talk:JohnnySolas|talk]]) 12:29, 16 April 2023 (UTC) | |||
@JohnnySolas Okay, we can probably just leave it like this then. The reason I was using :[[Template:item icon]] was to get a larger display icon, which helps maintain consistent row height if there are multiple lines like on Basking Shark. Theoretically we could extend the :[[Template:gather]] to have a size parameter (matching item icon), but I didn't want mess around with that because I only generally understand how creating templates works and I felt that had a much greater chance of breaking everything. [[User:OnyxVindicator|OnyxVindicator]] ([[User talk:OnyxVindicator|talk]]) 23:17, 16 April 2023 (UTC) | |||
Latest revision as of 23:18, 16 April 2023
@OnyxVindicator I've changed the template call from item icon back to gather as its broke a couple of pages that pull data from these fishing log pages. But if I'm honest these fishing logs were just created to pull the data for other pages. The information you are putting on would ideally be better on the individual fish pages I think JohnnySolas (talk) 20:12, 11 April 2023 (UTC)
@JohnnySolas My change to this page was a limited test, to see what issues it caused. I was intending to update more of the Fishing Log pages to give this data in a single at-a-glance table, to mimic the the overall style of Lulu's Tools for Ocean Fishing (https://ffxiv.pf-n.co/ocean-fishing). Teamcraft 90% works this way, but requires way too reading of multiple tables to figure out what's going on (and doesn't have additional requirements easily visible by those tables).
If this is interfering with the data pulls for other pages, would it be better to just revert the page entirely? Or perhaps move the table to the bottom of the page in its own section? OnyxVindicator (talk) 23:12, 15 April 2023 (UTC)
@OnyxVindicator - I don't think you need to change back just using :Template:gather instead of :Template:item icon should ensure the other pages pulls don't get affected - they are the same template expect gather adds an extra property so other pages can pull from it. Or yes if you want to put the table into its on section that works too and you could use item icon like you did. JohnnySolas (talk) 12:29, 16 April 2023 (UTC)
@JohnnySolas Okay, we can probably just leave it like this then. The reason I was using :Template:item icon was to get a larger display icon, which helps maintain consistent row height if there are multiple lines like on Basking Shark. Theoretically we could extend the :Template:gather to have a size parameter (matching item icon), but I didn't want mess around with that because I only generally understand how creating templates works and I felt that had a much greater chance of breaking everything. OnyxVindicator (talk) 23:17, 16 April 2023 (UTC)